gitops-engine feat: Add ability to hide certain annotations on secret resources

feat: Add ability to hide certain annotations on secret resources

Open svghadi opened this issue 1 year ago • 7 comments

trafficstars

Related to https://github.com/argoproj/argo-cd/issues/15693.

This PR implements core logic from argoproj/argo-cd#hide-annotations.md proposal to hide annotations on secret resources.

This change will be integrated with Argo CD via https://github.com/argoproj/argo-cd/pull/18216.

Integration results:

https://github.com/user-attachments/assets/f47d7b18-cfbc-4fef-8a63-cd7e670abcc7

May 14 '24 17:05 svghadi

May 14 '24 17:05 sonarqubecloud[bot]

@CodiumAI-Agent /review

Jun 30 '24 14:06 pasha-codefresh

⏱️ Estimated effort to review [1-5]	3
🧪 Relevant tests	Yes
🔒 Security concerns	No
⚡ Key issues to review	Possible Bug: The function `HideSecretData` now accepts an optional `hideAnnots` parameter which is used to specify which annotations should be hidden. However, there is no check to ensure that the annotations specified actually exist in the object, which could lead to unnecessary processing or errors if non-existent annotations are specified.
⚡ Key issues to review	Performance Concern: The method of hiding annotations involves iterating over each annotation for each object (target, live, orig) which could be inefficient, especially with a large number of annotations or secrets. Consider optimizing this process.