gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

feat: explicitly specify watch timeout for resClient.Watch

Open sheeponmeth opened this issue 5 years ago • 4 comments
trafficstars

If we are not set the watch timeout param on the client side, the k8s apiserver will use the default server timeout param. ArgoCD will re-list frequently when the server timeout is not long enough. Too many list call will increase system overhead.

sheeponmeth avatar Sep 28 '20 12:09 sheeponmeth

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 28 '20 12:09 CLAassistant

Codecov Report

Merging #151 into master will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   54.07%   54.17%   +0.09%     
==========================================
  Files          25       25              
  Lines        2415     2420       +5     
==========================================
+ Hits         1306     1311       +5     
  Misses        974      974              
  Partials      135      135              
Impacted Files Coverage Δ
pkg/cache/cluster.go 50.25% <100.00%> (+0.38%) :arrow_up:
pkg/cache/settings.go 60.71% <100.00%> (+3.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d25b8fd...ccd6eb2. Read the comment docs.

codecov-commenter avatar Sep 28 '20 12:09 codecov-commenter

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
26.0% 26.0% Duplication

sonarqubecloud[bot] avatar Oct 14 '20 06:10 sonarqubecloud[bot]

Codecov Report

Merging #151 into master will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   48.14%   48.23%   +0.09%     
==========================================
  Files          36       36              
  Lines        2858     2863       +5     
==========================================
+ Hits         1376     1381       +5     
  Misses       1339     1339              
  Partials      143      143              
Impacted Files Coverage Δ
pkg/cache/cluster.go 50.12% <100.00%> (+0.37%) :arrow_up:
pkg/cache/settings.go 60.71% <100.00%> (+3.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1dc4c5...500dd8a. Read the comment docs.

codecov-io avatar Oct 14 '20 06:10 codecov-io