gitops-engine
gitops-engine copied to clipboard
feat: explicitly specify watch timeout for resClient.Watch
If we are not set the watch timeout param on the client side, the k8s apiserver will use the default server timeout param. ArgoCD will re-list frequently when the server timeout is not long enough. Too many list call will increase system overhead.
Codecov Report
Merging #151 into master will increase coverage by
0.09%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 54.07% 54.17% +0.09%
==========================================
Files 25 25
Lines 2415 2420 +5
==========================================
+ Hits 1306 1311 +5
Misses 974 974
Partials 135 135
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/cache/cluster.go | 50.25% <100.00%> (+0.38%) |
:arrow_up: |
| pkg/cache/settings.go | 60.71% <100.00%> (+3.02%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d25b8fd...ccd6eb2. Read the comment docs.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities (and
0 Security Hotspots to review)
0 Code Smells
No Coverage information
26.0% Duplication
Codecov Report
Merging #151 into master will increase coverage by
0.09%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 48.14% 48.23% +0.09%
==========================================
Files 36 36
Lines 2858 2863 +5
==========================================
+ Hits 1376 1381 +5
Misses 1339 1339
Partials 143 143
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/cache/cluster.go | 50.12% <100.00%> (+0.37%) |
:arrow_up: |
| pkg/cache/settings.go | 60.71% <100.00%> (+3.02%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a1dc4c5...500dd8a. Read the comment docs.