argo-ui icon indicating copy to clipboard operation
argo-ui copied to clipboard

fix!: remove deprecated `durationMs` prop

Open agilgur5 opened this issue 1 year ago • 0 comments

Follow-up to https://github.com/argoproj/argo-ui/pull/535#issuecomment-2151143975, fixes the issue I discovered in https://github.com/argoproj/argo-cd/pull/19655#issuecomment-2305897525

Motivation

I previously left in durationMs for backward-compatibility so that you could use either, but I forgot to mark the types as optional, so both ended up being required by the typings, oops 🙃

Modifications

Instead of making them both confusingly optional (no way of doing "one of"), just remove the deprecated durationMs in another breaking change

agilgur5 avatar Aug 24 '24 13:08 agilgur5