argo-ui icon indicating copy to clipboard operation
argo-ui copied to clipboard

fix(deps): remove incorrectly duplicated peerDeps

Open agilgur5 opened this issue 1 year ago • 0 comments

Motivation

  • these are all inside of prod dependencies already (it has to be either or)

  • notably, antd had a version mismatch between dependencies and peerDependencies (and it was a major version difference, v5 vs v4 after #387)

    • dependencies supersede peerDependencies however, so the v5 dep was already used and the v4 dep was extraneous
    • see the yarn.lock file as evidence, as well as a downstream yarn.lock, such as Argo Workflows's
      • note how this commit has no changes to the yarn.lock file either
    • this mismatch did cause install warnings downstream as well, which were impossible to resolve given this mismatch in argo-ui's own deps
      • so those should now be resolved as well

Noticed this in https://github.com/argoproj/argo-workflows/pull/12097#discussion_r1375279098

Modifications

Remove duplicate deps from peerDependencies in package.json

Verification

No changes to yarn.lock, yarn install, build etc all still work fine. CI passes

agilgur5 avatar Jan 06 '24 22:01 agilgur5