argo-ui
argo-ui copied to clipboard
fix(deps): remove incorrectly duplicated peerDeps
Motivation
-
these are all inside of prod
dependenciesalready (it has to be either or) -
notably,
antdhad a version mismatch betweendependenciesandpeerDependencies(and it was a major version difference, v5 vs v4 after #387)dependenciessupersedepeerDependencieshowever, so the v5 dep was already used and the v4 dep was extraneous- see the
yarn.lockfile as evidence, as well as a downstreamyarn.lock, such as Argo Workflows's- note how this commit has no changes to the
yarn.lockfile either
- note how this commit has no changes to the
- this mismatch did cause install warnings downstream as well, which were impossible to resolve given this mismatch in
argo-ui's own deps- so those should now be resolved as well
Noticed this in https://github.com/argoproj/argo-workflows/pull/12097#discussion_r1375279098
Modifications
Remove duplicate deps from peerDependencies in package.json
Verification
No changes to yarn.lock, yarn install, build etc all still work fine. CI passes