applicationset icon indicating copy to clipboard operation
applicationset copied to clipboard

Published 20 hours ago • verified publisher icon argoproj

fix: filters skipped when more than one is specified (#521)

Open crenshaw-dev opened this issue 3 years ago • 4 comments

Simplify filter type detection.

Fixes #521

crenshaw-dev avatar Feb 18 '22 19:02 crenshaw-dev

@mmerrill3 can you take a look?

crenshaw-dev avatar Feb 18 '22 19:02 crenshaw-dev

I tried this code for a combination of repositoryMatch and branchMatch filters and it seems it doesn't work as expected. Only a default branch gets discovered, but not others.

oleg-glushak avatar Mar 26 '22 09:03 oleg-glushak

@oleg-glushak sounds like I need to write some more tests...

crenshaw-dev avatar Mar 28 '22 13:03 crenshaw-dev

@crenshaw-dev : Can u plz move this to argocd and close here?

rishabh625 avatar Apr 01 '22 11:04 rishabh625