applicationset icon indicating copy to clipboard operation
applicationset copied to clipboard

Published 20 hours ago • verified publisher icon argoproj

feat Gitlab list all repos

Open r0bobo opened this issue 3 years ago • 5 comments
trafficstars

This PR adds the feature for the Gitlab SCM generator to list all projects visible to the current user. I was not sure if you would want to modify the CRD to make this more explicit so now it just lists all projects if spec.generators.scmProvider.group is an empty string and spec.generators.scmProvider.includeSubgroups is just ignored in this case.

r0bobo avatar Jan 11 '22 17:01 r0bobo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 11 '22 17:01 CLAassistant

Are the failed Github unit tests due to a intermittent issue with Github? I couldn't get these to fail locally.

r0bobo avatar Jan 13 '22 21:01 r0bobo

They could be related to the move of git repo: github.com/argoproj-labs/applicationset has been moved to github.com/argoproj/applicationset.

wtam2018 avatar Jan 13 '22 22:01 wtam2018

You might want to wait for https://github.com/argoproj/applicationset/pull/455 to merge and sync.

wtam2018 avatar Jan 13 '22 22:01 wtam2018

@r0bobo : Can u please move this PR into argocd as applicationset is moved. If u find it laborious, i can do it on your behalf with your consent

rishabh625 avatar Apr 04 '22 05:04 rishabh625