argocd-image-updater icon indicating copy to clipboard operation
argocd-image-updater copied to clipboard

Update installation.md

Open Ileriayo opened this issue 1 year ago • 4 comments
trafficstars

Replace invalid GitHub url reference with the right one that points to the codebase on the master branch.

Ileriayo avatar Apr 30 '24 13:04 Ileriayo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.27%. Comparing base (7d93c7a) to head (7400bd5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   66.27%   66.27%           
=======================================
  Files          22       22           
  Lines        2150     2150           
=======================================
  Hits         1425     1425           
  Misses        591      591           
  Partials      134      134           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 02 '24 18:05 codecov-commenter

Pls see comments in https://github.com/argoproj-labs/argocd-image-updater/pull/533

chengfang avatar May 03 '24 18:05 chengfang

Pls see comments in #533

@Ileriayo Based on the discussion in #533 , do you agree this change is no longer needed?

We could append something like below to clarify a bit:

This directory can be viewed here

chengfang avatar May 07 '24 18:05 chengfang

Correct! @chengfang

Ileriayo avatar May 09 '24 02:05 Ileriayo

LGTM

pasha-codefresh avatar May 14 '24 19:05 pasha-codefresh

@Ileriayo could you please fix DCO?

pasha-codefresh avatar May 14 '24 19:05 pasha-codefresh

@Ileriayo could you please fix DCO?

Done @pasha-codefresh

Ileriayo avatar May 16 '24 05:05 Ileriayo