argmin
argmin copied to clipboard
argmin-rs
Add nalgebra 0.33 support
Since the Allocator trait changed, I added a trait alias to mimic the old Allocator trait.
Hi, thanks also for this PR! Would you mind rebasing now that #504 is merged?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.49%. Comparing base (
a9e3eb7) to head (168d918). Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #505 +/- ##
==========================================
- Coverage 92.08% 91.49% -0.60%
==========================================
Files 178 178
Lines 24455 23623 -832
==========================================
- Hits 22520 21613 -907
- Misses 1935 2010 +75
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could you add testing the 0.33 version to the CI, please? This would be the appropriate place: https://github.com/argmin-rs/argmin/blob/be2444ed875190f361be7cc95a39e63a0c951e68/.github/workflows/ci.yml#L120-L130
Hi @stefan-k, it appears that @0e4ef622 added CI support in https://github.com/0e4ef622/argmin/commit/168d918a682b9c13ce69d0e76df02ac4e533aa8f.
Apologies for being so absent recently. I'll try to address some of the open pull requests on Sunday.
Apologies for being so absent recently. I'll try to address some of the open pull requests on Sunday.
No problem at all, we all get busy! 😄 Thank you for everything you do!
argmin is fantastic, and a lot of people really admire and appreciate your hard-work (I know I do).
No problem at all, we all get busy! 😄 Thank you for everything you do!
argminis fantastic, and a lot of people really admire and appreciate your hard-work (I know I do).
Thanks for the kind words! :) LGTM, Huge thanks to @0e4ef622 for your work and for addressing my request! :)