argmin icon indicating copy to clipboard operation
argmin copied to clipboard

Fix clippy lints

Open 0e4ef622 opened this issue 1 year ago • 1 comments

Replace std::*::EPSILON with *::EPSILON, etc.

0e4ef622 avatar Aug 04 '24 16:08 0e4ef622

Not exactly sure what to do about the remaining CI failures.

0e4ef622 avatar Aug 04 '24 22:08 0e4ef622

Thanks for your work and apologies for the long wait!

The argmin-math tests are broken due to #509, will have to fix that in another PR or I may just do it in this one.

stefan-k avatar Aug 31 '24 08:08 stefan-k

Fixes #509

stefan-k avatar Aug 31 '24 09:08 stefan-k

Codecov Report

Attention: Patch coverage is 99.40476% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.49%. Comparing base (a9e3eb7) to head (e031083).

Files with missing lines Patch % Lines
crates/spectator/src/connection.rs 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   92.08%   91.49%   -0.60%     
==========================================
  Files         178      178              
  Lines       24455    23623     -832     
==========================================
- Hits        22520    21613     -907     
- Misses       1935     2010      +75     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 31 '24 12:08 codecov-commenter