ares icon indicating copy to clipboard operation
ares copied to clipboard

Borderless Mode (Windows)

Open MartyShepard opened this issue 1 year ago • 5 comments

Hello, i have added a Borderless mode for  the Windows version.

I only use Ares in window desktop mode with shaders and bezels but the frame around the window was bothering me and I still use Windows 7.

Can be activated via the command line (--noBorderless/ --Borderless) or via the menu. or via Hotkey.

Might be useful for some users. :)

I have no technical knowledge of Linux or Mac APIs.

greetings Edit: I use Msys2 g++.exe (Rev1, Built by MSYS2 project) 11.3.0 under Windows 7

MartyShepard avatar Feb 15 '24 19:02 MartyShepard

Most comments should be removed as an accepted PR will credit the written code to the appropriate author.

kev4cards avatar Feb 16 '24 05:02 kev4cards

Hello,

Ah OK, the comments are gone. They only serve as "bookmarks" so that you know where something has been changed.

Thanks and greetings. :)

MartyShepard avatar Feb 16 '24 11:02 MartyShepard

Hello,

Ah OK, the comments are gone. They only serve as "bookmarks" so that you know where something has been changed.

Thanks and greetings. :)

You can probably also remove the "Marty2Life Borderless BEG" and "Randloses Fenster Commandline --------- BEGIN" comments since those are not necessary.

Also are you going to update the hardcoded value with something else, or is that hardcoded permanent for the foreseeable future?

DerekTurtleRoe avatar Feb 18 '24 08:02 DerekTurtleRoe

Hello,
Ah OK, the comments are gone. They only serve as "bookmarks" so that you know where something has been changed.
Thanks and greetings. :)

You can probably also remove the "Marty2Life Borderless BEG" and "Randloses Fenster Commandline --------- BEGIN" comments since those are not necessary.

Also are you going to update the hardcoded value with something else, or is that hardcoded permanent for the foreseeable future?

No, the value is "Temporary Hard" and needs to be refined by a dynamic height calculation through the API in future.

MartyShepard avatar Feb 18 '24 14:02 MartyShepard

Some questions and feedback.

I know we don't have a formal document that specifies coding style, but please try to match the style of surrounding code.

I stopped pointing out tab/spacing issues after a while, but inconsistent tab-width seems to be a common thread here.

I hope the space and tab are correct. I use Notepad++, changed tab to 2 spaces .

greetings :)

MartyShepard avatar Feb 23 '24 15:02 MartyShepard