cpp-test-action icon indicating copy to clipboard operation
cpp-test-action copied to clipboard

Add configuration flag to allow running the tests with valgrind

Open aentinger opened this issue 2 years ago • 1 comments

Describe the request

As pointed out by @tttapa over here we can not enable address sanitizers since valgrind in CMakeLists.txt would refuse to run it. Consequently it would be desirable to have a configuration flag that would allow to disable using valgrind for running the tests.

Describe the current behavior

arduino/cpp-test-action always uses valgrind when running the unit tests, though there are situations where this may be not sensible to do.

'arduino/cpp-test-action' version

main

Additional context

No response

Issue checklist

  • [X] I searched for previous requests in the issue tracker
  • [X] I verified the feature was still missing when using the latest version
  • [X] My request contains all necessary details

aentinger avatar Aug 07 '23 04:08 aentinger

Another option could be to have a flag to switch between normal builds, valgrind builds, and Asan+UBsan builds (i.e. making the cpp-test-action aware of the sanitizers, rather than enabling them manually in the consuming projects).

tttapa avatar Aug 08 '23 19:08 tttapa