ArduinoBearSSL icon indicating copy to clipboard operation
ArduinoBearSSL copied to clipboard

clientRead: keep reading if client not connected but data is available

Open pennam opened this issue 3 years ago • 2 comments

Should fix #56

@Jeroen88 could you give it a spin?

pennam avatar Sep 26 '22 12:09 pennam

Memory usage change @ 832f30a45403fac23aba5f20ae0dfa50bb51cf53

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 :small_red_triangle: 0 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 :small_red_triangle: 0 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SHA1
flash
% examples/SHA1
RAM for global variables
% examples/SHA256
flash
% examples/SHA256
RAM for global variables
% examples/WiFiSSLClient
flash
% examples/WiFiSSLClient
RAM for global variables
% examples/MKRGSMSSLClient
flash
% examples/MKRGSMSSLClient
RAM for global variables
%
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0
Click for full report CSV
Board,examples/SHA1<br>flash,%,examples/SHA1<br>RAM for global variables,%,examples/SHA256<br>flash,%,examples/SHA256<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/MKRGSMSSLClient<br>flash,%,examples/MKRGSMSSLClient<br>RAM for global variables,%
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,,,,,8,0.0,0,0.0

github-actions[bot] avatar Sep 26 '22 12:09 github-actions[bot]

I actually do not use this library, so I can not check it, but the code looks good to me.

Jeroen88 avatar Sep 28 '22 16:09 Jeroen88

Closing this because c->connected() should return true if client socket is truly connected or there is data available in the read buffer.

pennam avatar Jul 17 '24 07:07 pennam