graphql-tools icon indicating copy to clipboard operation
graphql-tools copied to clipboard

Declare global PromiseWithResolvers type

Open samchungy opened this issue 1 year ago • 2 comments
trafficstars

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Declares a global type to allow builds for users who are not using ESNext to pass. This takes a similar approach to other libraries where the DOM lib is not present.

Related #6353

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Locally editing the node module with the global

Test Environment:

  • NodeJS: 20

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works ^ Not sure how. Can confirm it now passes locally
  • [x] New and existing unit tests and linter rules pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

Further comments

samchungy avatar Oct 03 '24 00:10 samchungy