graphql-tools icon indicating copy to clipboard operation
graphql-tools copied to clipboard

fix(federation/delegate): support `@provides` and do not merge errors and resolved objects

Open ardatan opened this issue 1 year ago • 2 comments
trafficstars

Fixes on @graphql-tools/delegate;

If a subschema returns an error for specific field that is already resolved by another subschema, the error should not be merged with the resolved object.

Improvements on @graphql-tools/federation;

Respect @provides to optimize the query plan

ardatan avatar May 16 '24 10:05 ardatan

🦋 Changeset detected

Latest commit: a48648c4a93cda3c482f15f98e4eb0ff8023c670

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-tools/delegate Patch
@graphql-tools/federation Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 16 '24 10:05 changeset-bot[bot]

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 336      ✗ 0  
     data_received..................: 39 MB   3.9 MB/s
     data_sent......................: 144 kB  14 kB/s
     http_req_blocked...............: avg=3.81µs   min=1.98µs   med=2.51µs   max=178.57µs p(90)=3.64µs  p(95)=3.85µs  
     http_req_connecting............: avg=683ns    min=0s       med=0s       max=114.82µs p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=55.58ms  min=48.22ms  med=51.27ms  max=152.07ms p(90)=60.08ms p(95)=90.14ms 
       { expected_response:true }...: avg=55.58ms  min=48.22ms  med=51.27ms  max=152.07ms p(90)=60.08ms p(95)=90.14ms 
     http_req_failed................: 0.00%   ✓ 0        ✗ 168
     http_req_receiving.............: avg=136.84µs min=105.12µs med=129.55µs max=503.85µs p(90)=149.6µs p(95)=183.61µs
     http_req_sending...............: avg=24.84µs  min=17µs     med=24.33µs  max=75.08µs  p(90)=31.21µs p(95)=34.78µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=55.41ms  min=48.06ms  med=51.12ms  max=151.51ms p(90)=59.93ms p(95)=89.99ms 
     http_reqs......................: 168     16.72608/s
     iteration_duration.............: avg=59.76ms  min=51.72ms  med=55.29ms  max=162.25ms p(90)=67.63ms p(95)=93.86ms 
     iterations.....................: 168     16.72608/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]