Mojtaba Samimi
Mojtaba Samimi
> I've tried rebasing, but it's quite hard. I think the easiest way to get this PR going again, is to make a new branch off master and apply the...
@birkskyum simply FYI: I noticed an build problem requiring map arcgis styles that were in json format. I fixed it but converting then to js files in [8ba1116](https://github.com/plotly/plotly.js/pull/6909/commits/8ba111610bd50f0b9a93b3a0f6c64f5d66f8914f). Then only...
> If the requirejs is missing CI tests, what's the step to manually test it? @birkskyum It's not missing on CI. For local testing you could run npm run build...
@birkskyum That object looks like the d3 object not Plotly. The amd header was present in the build last time I checked it. I suspect this might be related to...
> @birkskyum That object looks like the d3 object not Plotly. The amd header was present in the build last time I checked it. I suspect this might be related...
How about the intermediate @plotly/d3 versions e.g. 3.8.0?
> The `npm run test-jasmine -- surface` and `parcoords` appear to pass everything locally, so I wonder why they fail in ci @birkskyum OK. Something strange seems to start happening...
> > The `npm run test-jasmine -- surface` and `parcoords` appear to pass everything locally, so I wonder why they fail in ci > > @birkskyum OK. Something strange seems...
One could argue it's actually more than that. On CI if we look at CI-build task in isolation it used to take 90 seconds. Now it's only 3 seconds. So...
@alexcjohnson @gvwilson This PR is ready to go :rocket: