archinstall
archinstall copied to clipboard
Add hostname and locales as parameters to `minimal_installation()`
- This resolves: https://github.com/archlinux/archinstall/issues/1200#issuecomment-1130564952
PR Description:
Fix occurrence of duplicate calls to set_hostname() and set_locale() by adding hostname and locales as parameters to minimal_installation().
Tests and Checks
- [ ] I have tested the code!
~~I can't get the flake8 linting to pass. What would be the acceptable way to format the long if statement in examples/guided.py?~~
Edit: I misunderstood the output of flake8, the problem was with the function call missing names for named parameters not the formatting of the long if statement. It is fixed now and the flake8 linting run was successful.
Updated this pull request to use locales instead of locale in preparation of pull request to add support for https://github.com/archlinux/archinstall/issues/1435.
Great work and thank you for being patient with me! I finally got around to merge some PR's!