archinstall icon indicating copy to clipboard operation
archinstall copied to clipboard

Migrate away from using "harddrives" in --conf and rely on --disk-layout souly

Open Torxed opened this issue 3 years ago • 2 comments

This is a non-time-critical issue and can be done whenever really.

So the background to me creating this issue is mainly nit picking. The current state works, but this would eliminate issues when people modify their --disk-layout to include a secondary drive but forget to adding it to --conf.

Assuming --disk-layout:

{
    "/dev/sda": {
        "partitions": [
            ...
        ],
        "wipe": true
    },
    "/dev/sdb": {
        "partitions": [
            {
                ...
            }
        ],
        "wipe": true
    }
}

But --conf contains:

{
    "harddrives": [
        "/dev/sda"
    ],
    ...
}

There will be an error where device_instance is never set for /dev/sdb, because it never got put through: https://github.com/archlinux/archinstall/blob/65212a46aa43fadb2b0ee88b46b573765d7be9f9/examples/guided.py#L128-L131

Moving to --disk-layout filtered list of harddrives makes more sense.

Torxed avatar Aug 28 '22 19:08 Torxed

This would be awesome :)

svartkanin avatar Aug 28 '22 21:08 svartkanin

Hehe indeed, I spent around a week trying to figure out why my configurations didn't work when debugging all the other issues. Turns out I forgot to add /dev/sdb.. So I'm very much in favor of getting this done in time for the v2.5.2 or thereabout ^^

For now I'm pretty satisfied with the state to release v2.5.1 tbh. As it's a lot of small patches that really needs to get out there.

Torxed avatar Aug 28 '22 22:08 Torxed

This should be resolved as we switched to a single config file

svartkanin avatar Sep 17 '23 09:09 svartkanin