archinstall icon indicating copy to clipboard operation
archinstall copied to clipboard

Invert mypy file checking and add pre-commit hook

Open svartkanin opened this issue 3 years ago • 2 comments
trafficstars

Some changes to how mypy is applied:

  • We're now excluding files to be checked by mypy instead of including them explicitly, which means that all new files will have to be compliant

Add an OPTIONAL pre-commit hook configuration file, this run some checks before actually committing which should indicate if github actions are going to fail :) The hooks can easily be installed with

pip install pre-commit
pre-commit install

svartkanin avatar Jun 20 '22 10:06 svartkanin

Extracted the mypy configuration from the github action into it's own mypy.ini configuration so it can be called easily from github and the pre-commit hook

svartkanin avatar Jun 26 '22 02:06 svartkanin

@Torxed If you're okay with this one could we merge it in? Otherwise it will inevitably cause a lot of conflicts whenever something else gets merged :)

svartkanin avatar Aug 07 '22 06:08 svartkanin

Has been merged into https://github.com/archlinux/archinstall/pull/1604 and will be added with it

svartkanin avatar Mar 13 '23 08:03 svartkanin