DocsGPT
DocsGPT copied to clipboard
Enhancement on Edit Button UI
Issue: I've come accrossed the DocsGPT's UI and noticed a small nitpicking detail that I want to point out.
Explanation:
The Edit button besides the user's question looks like it is slightly (pixel level) closer to the bottom right corner instead of being centered.
This is because the edit.svg has a white, horizontal bar at the bottom right of the svg, which shifts the "center of gravity" of the icon a little bit towards bottom right.
Solution1:
One simple solution is to specify the top and left padding to be p-1.5, result is as follows:
Solution2:
Another one is to change the svg to one without the bottom right white line.
Please let me know if this needs a change and if so which approach you think works out better :) Whenever you're ready I can pull up a PR for you to review.
Hey @ManishMadan2882 and @tenokami what do you think?
@M4cr0Chen Hey, you have a very good eye! I think your first solution would suffice 👍
@M4cr0Chen Any additional suggestions would be appreciated
another suggestion I would like to provide is the response message box padding and radius. The padding looks a little off as if the texts is closer to the upper. The box radius also can be optimized to fit the font size better.
What we currently have:
My suggested layout:
Can you assign this issue to me? Thanks a lot :)
@M4cr0Chen I agree with the box radius. But not sure what u meant by the top padding. I've just placed equal sized blocks for measurement and text block is closer to the bottom
I would like to contribute to this repo, I request you to assign me
@nikunj-kohli Since the issue is mostly solved, Could you please clarify what specific improvement within this issue you'd like to work on?