DocsGPT icon indicating copy to clipboard operation
DocsGPT copied to clipboard

Fixed Responsiveness for Hero and Conversation

Open Vaibhav91one opened this issue 1 year ago • 2 comments

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fixes for Hero and Conversation component.

  • Why was this change needed? (You can also link to an open issue here) The UI was buggy when the sidebar closes for mobile screens. https://github.com/arc53/DocsGPT/issues/1192

  • Other information: image

Vaibhav91one avatar Oct 02 '24 16:10 Vaibhav91one

@Vaibhav91one is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 02 '24 16:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 7:28pm

vercel[bot] avatar Oct 03 '24 19:10 vercel[bot]

Hi @ManishMadan2882

  • Yes, I think the Height issue is fixed on the official website,
  • About the tagline I think it looks better in mobile also, if done correctly.
  • Lastly, When sidebar closes this is how it looks, which i think is a little off.

Ultimately, Its your repo your rules. 😊

Official: image

From my branch: image

Vaibhav91one avatar Oct 04 '24 11:10 Vaibhav91one

Hi @Vaibhav91one Agree with the 3rd point, but we need to make sure that it doesn't affect the desktop version. It looks like a issue in Tablet screens, also the tagline will be good to have in tab. Thanks!

ManishMadan2882 avatar Oct 04 '24 22:10 ManishMadan2882

Hi @Vaibhav91one Agree with the 3rd point, but we need to make sure that it doesn't affect the desktop version. It looks like a issue in Tablet screens, also the tagline will be good to have in tab. Thanks!

HI @ManishMadan2882, So, the changes that will be done are done in previous PR in hero and conversation components. I will submit a new PR with the updated branch. Works?

Vaibhav91one avatar Oct 06 '24 03:10 Vaibhav91one

Absolutely @Vaibhav91one .

ManishMadan2882 avatar Oct 06 '24 10:10 ManishMadan2882

Hey @Vaibhav91one , there is also a chance we would request you to fix as it aligns with the query bar issue.

image

Currently when we close the side bar and ask a query the query bar and the generated text arent aligned as shown in the picture. So we need to fix this and make sure they are aligned.

shelar1423 avatar Oct 07 '24 11:10 shelar1423

Hey @Vaibhav91one , there is also a chance we would request you to fix as it aligns with the query bar issue.

image

Currently when we close the side bar and ask a query the query bar and the generated text arent aligned as shown in the picture. So we need to fix this and make sure they are aligned.

@shelar1423 , You mean the Answer and the ouput right?

Vaibhav91one avatar Oct 07 '24 14:10 Vaibhav91one

I think it looks like after sidebar is closed, the input box is not really centered, and that makes it mismatched with the output. Basically all things need to be aligned well here

dartpain avatar Oct 07 '24 15:10 dartpain

Please find the below PR for the changes. Pull Request

Vaibhav91one avatar Oct 09 '24 15:10 Vaibhav91one