DocsGPT icon indicating copy to clipboard operation
DocsGPT copied to clipboard

Drag and drop training, from input box

Open dartpain opened this issue 1 year ago • 6 comments

Basically should trigger from file training process once a user drags and drops a file into the input box

dartpain avatar Sep 30 '24 21:09 dartpain

Hey, can you please assign this to me?

sahil9001 avatar Oct 01 '24 04:10 sahil9001

Just wanted to ask, wouldn't this be cost inefficient? Like a user might just drop the file accidentally and the system would train on it. I feel that it should be trained when user submits the file to the system instead of dropping it directly.

Please let me know if you have any reasoning to this

sahil9001 avatar Oct 01 '24 04:10 sahil9001

Im not sure may people put things into the input box, even on github it assumes the your are uploading an attachment. Would agree if it was a larger area.

dartpain avatar Oct 01 '24 08:10 dartpain

Im not sure may people put things into the input box, even on github it assumes the your are uploading an attachment. Would agree if it was a larger area.

But that's upload, right? Wouldn't training consume COGS/cost to DocsGPT with no reason? Assuming if a user uploads a big text file (1M Tokens), and then removes, let's say this happens 10 times, wouldn't the cost for 10M tokens incur on DocsGPT?

sahil9001 avatar Oct 01 '24 09:10 sahil9001

Once user drags a file we should pop open the training modal to show progress. In this case we can just preload that document into modal and wait till user clicks train

dartpain avatar Oct 01 '24 09:10 dartpain

Got it, I will raise a PR for this. Thanks!

sahil9001 avatar Oct 01 '24 09:10 sahil9001

Is this issue still open? I want to work on it. Please assign me this task. Thank you

anurag-4508 avatar Oct 04 '24 03:10 anurag-4508

@sahil9001

dartpain avatar Oct 04 '24 19:10 dartpain

hey @dartpain sorry i missed this, i am working on it.

sahil9001 avatar Oct 06 '24 03:10 sahil9001

@dartpain Can you please clear this one last time? I mean the flow, it is —

  1. User picks a file.
  2. It auto uploads.
  3. Training modal opens up and file auto trains
  4. Finish

Is this correct?

sahil9001 avatar Oct 07 '24 03:10 sahil9001

Think we decided to change it a bit based on you comments.

  1. Users drops file into the input box
  2. Upload box open, not training yet, just preloaded the document CleanShot 2024-10-07 at 11 21 57@2x

dartpain avatar Oct 07 '24 10:10 dartpain

@sahil9001 is there any update?

ManishMadan2882 avatar Oct 21 '24 11:10 ManishMadan2882

No, you can take it up if you want to, occupied with other work

sahil9001 avatar Oct 21 '24 11:10 sahil9001

@anurag-4508

ManishMadan2882 avatar Oct 21 '24 11:10 ManishMadan2882

@ManishMadan2882 what is meant by input box here the textarea or the upload file from device?

Srayash avatar Oct 23 '24 11:10 Srayash

Hi @tenokami, We are planning to have a feature such that we hover a file over the input box in the Conversations, and the file drop modal pops up, can you please make it more clear in terms of UX.

ManishMadan2882 avatar Oct 23 '24 12:10 ManishMadan2882

Hi @tenokami, We are planning to have a feature such that we hover a file over the input box in the Conversations, and the file drop modal pops up, can you please make it more clear in terms of UX.

I'm working on design for this and will send you

tenokami avatar Oct 24 '24 15:10 tenokami

@ManishMadan2882

https://www.figma.com/proto/OXLtrl1EAy885to6S69554/DocsGPT?node-id=4924-7643&t=jN2h9b2qkZbZUC3B-1 https://www.figma.com/proto/OXLtrl1EAy885to6S69554/DocsGPT?node-id=4924-7780&t=jN2h9b2qkZbZUC3B-1

Drag and drop 2 Drag and drop 2 Dark

https://www.figma.com/design/OXLtrl1EAy885to6S69554/DocsGPT?node-id=0-1&t=jN2h9b2qkZbZUC3B-1

tenokami avatar Oct 24 '24 20:10 tenokami

Hey @ManishMadan2882 @tenokami I would like to work on this issue can you please assign it to me please. Thank you.

AkashJana18 avatar Oct 28 '24 14:10 AkashJana18

hey @AkashJana18 I'm working on this issue, expect a PR soon.

Srayash avatar Oct 28 '24 14:10 Srayash

Hey @Srayash Is is still active?

dartpain avatar Nov 21 '24 14:11 dartpain

Yes, had my end semester exams going on. Will be working on it soon.

Srayash avatar Nov 21 '24 14:11 Srayash

I have set up the dropzone on the conversation bubble currently, onDrop logs the dropped files to the console.(#1459 ) I'll need help with the onDrop function to upload and turn the modal state to active.

Srayash avatar Nov 27 '24 17:11 Srayash