DocsGPT icon indicating copy to clipboard operation
DocsGPT copied to clipboard

Integrated Milvus Vector DB into main

Open Jacksonxhx opened this issue 1 year ago • 2 comments

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Integration of Milvus Vector DB

  • Why was this change needed? (You can also link to an open issue here)

  • Provide a new DB choice

  • Other information:

Jacksonxhx avatar Jul 30 '24 09:07 Jacksonxhx

@Jacksonxhx is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 30 '24 09:07 vercel[bot]

Hi, I might an authorization to delpoy

Jacksonxhx avatar Jul 30 '24 09:07 Jacksonxhx

Hi, is there anyone who can help me with the Vercel deployment?

Jacksonxhx avatar Aug 21 '24 03:08 Jacksonxhx

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 10:45pm

vercel[bot] avatar Aug 21 '24 14:08 vercel[bot]

we need this feature, @dartpain could you please help to review it?

zc277584121 avatar Sep 03 '24 03:09 zc277584121

So few comments on this PR,

  1. I added filter parameter to search method
  2. Lots of upgrades to make it all work
  3. Dont use Milvus here as local file - its recommended to deploy it separately, as worker and backend containers will query it.

Finally to install in just add langchain-milvus==0.1.4 to your requirements txt file

dartpain avatar Sep 05 '24 22:09 dartpain

Codecov Report

Attention: Patch coverage is 50.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 22.20%. Comparing base (817fc5d) to head (2ff8c0b). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
application/vectorstore/base.py 44.44% 10 Missing :warning:
application/vectorstore/milvus.py 50.00% 10 Missing :warning:
application/vectorstore/faiss.py 0.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
+ Coverage   21.90%   22.20%   +0.29%     
==========================================
  Files          81       82       +1     
  Lines        3698     3734      +36     
==========================================
+ Hits          810      829      +19     
- Misses       2888     2905      +17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 05 '24 22:09 codecov[bot]