kube-arangodb icon indicating copy to clipboard operation
kube-arangodb copied to clipboard

CRD arangomember is deployed by both charts: kube-arangodb and kube-arangodb-crd

Open BernhardBerbuir opened this issue 4 years ago • 4 comments

The CRD arangomember is deployed by both charts: kube-arangodb and kube-arangodb-crd => the last chart wins

I would suggest that only the chart kube-arangodb-crd create CRDs.

BernhardBerbuir avatar Jun 18 '21 14:06 BernhardBerbuir

Hello!

We want to include CRD creation into kube-arangodb chart into crds section. It is recommended by Helm3 right now.

It was first step for migration, we will move other charts under kube-arangodb.

If order of installation is like described in docs - first kube-arangodb-crd, then kube-arangodb- everything should go fine.kube-arangodb-crdshould install new CRD, after thatkube-arangodb` should be fine that CRD exists. If this statement is wrong we will update flow, but it passed all manual tests.

Best Regards, Adam.

ajanikow avatar Jun 22 '21 11:06 ajanikow

In my opinion it would be better to separate K8S Cluster admin task and K8S namespace admin tasks as they are different concerns:

  • cluster admin: creates CRDs, ClusterRoles and ClusterColebinding
  • Namespace admin: creates ServiceAccount and ArangoDB operator

Otherwise only a K8S Cluster admin can use the chart

BernhardBerbuir avatar Jun 25 '21 09:06 BernhardBerbuir

Hello!

We can achieve isolation with this approach - CRD from helm are installed as optional. Currently, it is split like this:

  • In kube-arangodb we support namespaced mode, so it can be installed within namespace (without admin access). You can skip CRD installation by helm command flag (--skip-crds).
  • CRD can be installed before by system-admin - even using kubectl, helm command - directly from kube-arangodb chart.

Best Regards, Adam.

ajanikow avatar Jun 30 '21 08:06 ajanikow

Thoughts on adding a helm values to wrap the CRD that can be disabled from the values.yaml? With some CD systems like ArgoCD, we can't pass in command line arguments to helm

sarahhenkens avatar Sep 15 '21 05:09 sarahhenkens