arangodb-php icon indicating copy to clipboard operation
arangodb-php copied to clipboard

Issue #290 - Support PHP 8.1

Open Sweetchuck opened this issue 3 years ago • 8 comments
trafficstars

Issue #290 - Support PHP 8.1

Sweetchuck avatar Jan 18 '22 21:01 Sweetchuck

Fresh avocado detected! Welcome and thank you for your contribution @Sweetchuck. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.

cla-bot[bot] avatar Jan 18 '22 21:01 cla-bot[bot]

Fresh avocado detected! Welcome and thank you for your contribution @Sweetchuck. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.

cla-bot[bot] avatar Jan 18 '22 22:01 cla-bot[bot]

Hello @Sweetchuck can you fix the PR please ? :D

Geolim4 avatar Mar 30 '22 19:03 Geolim4

@Geolim4

  1. Download a PDF
  2. print it on papper
  3. fill the form and sign it
  4. send it back with fax (or other way)

No. I am not gonna do that.

ArangoDB should reconsider the contribution workflow.

I would happily contribute more. For example remove the tests/.phpunit.result.cache from the repository.

Sweetchuck avatar Mar 30 '22 19:03 Sweetchuck

@Geolim4

1. Download a PDF

2. print it on papper

3. fill the form and sign it

4. send it back with fax (or other way)

No. I am not gonna do that.

ArangoDB should reconsider the contribution workflow.

I would happily contribute more. For example remove the tests/.phpunit.result.cache from the repository.

Wait what ? They require to sign and re-send a PDF ? oO Didn't noticed that, my bad. This new "CLA" trend is completely counterproductive.

Geolim4 avatar Mar 30 '22 19:03 Geolim4

I just rebased this branch to the latest „devel” branch.

Sweetchuck avatar Mar 30 '22 20:03 Sweetchuck

The fail is totally irrelevant.

\ArangoDBClient\AdminTest::testGetServerMetrics line 262. expected: arangodb_server_statistics_server_uptime_total most closer actual: arangodb_server_statistics_server_uptime


But after that: static::assertEquals("counter", $metric["type"]); actual: gauge


static::assertTrue(is_numeric($metric["sum"]));
Undefined index: sum
/.../triagens/arangodb-php-3.x/tests/AdminTest.php:276


Docker image arangodb/arangodb-preview:3.9.0-nightly as defined in tests/travis/setup_arangodb.sh

Why nightly?

Sweetchuck avatar Mar 30 '22 21:03 Sweetchuck

Related Issue: #294

Sweetchuck avatar Apr 01 '22 18:04 Sweetchuck