crayon-syntax-highlighter
crayon-syntax-highlighter copied to clipboard
Bug fix: Removed string "px !important;" from $font_size which should have only number seeing its usage
removed ". 'px !important;'" because its value is used as number and it is yielding warning like
Notice: A non well formed numeric value encountered in /var/www/web/app/plugins/crayon-syntax-highlighter/crayon_formatter.class.php on line 118
Line 118: $toolbar_height = $font_size * 1.5 . 'px !important;';
So "$font_size" should not have the string 'px !important;' but it should have only number
And this string is added in different lines, so removing string from $font_size should be O.K.
I was having the same issue and your fix works. Hopefully, this will get merged into the code.
I think it would be better to change on lines 118 & 119 $font_size by $_font_size because $font-size is used on line 121.
This PR isn't a valid fix. As @xavier-bs noted, the fix should be made at lines 118 & 119.