crayon-syntax-highlighter icon indicating copy to clipboard operation
crayon-syntax-highlighter copied to clipboard

Bug fix: Removed string "px !important;" from $font_size which should have only number seeing its usage

Open hikarine3 opened this issue 7 years ago • 3 comments

removed ". 'px !important;'" because its value is used as number and it is yielding warning like

Notice: A non well formed numeric value encountered in /var/www/web/app/plugins/crayon-syntax-highlighter/crayon_formatter.class.php on line 118

Line 118: $toolbar_height = $font_size * 1.5 . 'px !important;';

So "$font_size" should not have the string 'px !important;' but it should have only number

And this string is added in different lines, so removing string from $font_size should be O.K.

hikarine3 avatar Apr 15 '18 02:04 hikarine3

I was having the same issue and your fix works. Hopefully, this will get merged into the code.

eclectic-coding avatar Jun 09 '18 12:06 eclectic-coding

I think it would be better to change on lines 118 & 119 $font_size by $_font_size because $font-size is used on line 121.

xavier-bs avatar Apr 10 '19 20:04 xavier-bs

This PR isn't a valid fix. As @xavier-bs noted, the fix should be made at lines 118 & 119.

johnalarcon avatar Sep 07 '19 07:09 johnalarcon