aral-matrix
aral-matrix
Thanks for the additional data point. If I am not mistaken, MSYS does use MinGW as a compiler? I could see implementing your fix specifically for mingw (32 or 64)...
> So, proposed solution should be OK for GCC or clang with MinGW runtime. > But there are other compilers with different runtimes like Borland (kind of clang, I suppose)....
When you say > both my patch and "_MSC_VER" patch worked. do you mean the patch to the development branch? This is what I implemented: ``` // don't use "stat"...
I uploaded a patch to the testing branch though - would you be so kind to test that for me with your MinGW setup?
Go to: https://github.com/troldal/OpenXLSX/tree/development-aral Then: ``` Code v``` -> ```Download ZIP``` (same as for the master branch) (Resulting link would be: https://github.com/troldal/OpenXLSX/archive/refs/heads/development-aral.zip)
Excellent! Thank you for the feedback :) Now I only need a confirmation - from anyone - that it didn't break anything on MSVC. But I am inclined to just...
merged into master today.
I have implemented cell merging functionality in my development branch & hope that it will come here to the repo eventually. If possible, please keep the posts in English (I...
Functionality is implemented in the main branch. Closing this.
This issue has been fixed in the May 2024 Update.