aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[Feature Request] event handle api return txhash

Open liuxiaobleach opened this issue 3 years ago • 4 comments
trafficstars

🚀 Feature Request

Now, the api for querying event by handle only return version. While most system need the txhash. Can we support returning txhash in this api? https://fullnode.devnet.aptoslabs.com/v1/spec#/operations/get_events_by_event_handle

liuxiaobleach avatar Nov 01 '22 01:11 liuxiaobleach

Transaction version is synonymous with the hash, and is immutable. If the hash is needed it can be pulled from the API via the version.

I'm curious about the exact use case that doesn't support version.

gregnazario avatar Nov 08 '22 03:11 gregnazario

Thx for your relay. I also know version is equal to txhash. But in some evm case. For example, some exist apps which want to support aptos without much code change. Txhash is make sense.

liuxiaobleach avatar Nov 10 '22 07:11 liuxiaobleach

While I know I can get the txhash by version with another api, but get the txhash just in event handle can save more requests. And I think it is not hard to get the txhash and return it in curretn event api.

liuxiaobleach avatar Nov 10 '22 07:11 liuxiaobleach

Version also can support my requirement. But it can be more easy to use for multi bridge DAPP, if the event return txhash. Developers do not need to change their code when use aptos.

liuxiaobleach avatar Nov 10 '22 07:11 liuxiaobleach

@gregnazario Any idea?

liuxiaobleach avatar Nov 18 '22 09:11 liuxiaobleach

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

github-actions[bot] avatar Jan 03 '23 01:01 github-actions[bot]