aptabase-swift icon indicating copy to clipboard operation
aptabase-swift copied to clipboard

Fix device model identifier for Mac

Open manucheri opened this issue 1 year ago • 1 comments

uname returns x86_64 (or Apple Silicon equivalent) as the device name for Macs. Get the device name in another way for Mac devices. If it fails (it shouldn't AFAIK but still), fallback to the default way (which I guess can be represented as "unknown Mac" or similar).

manucheri avatar Apr 29 '24 16:04 manucheri

@goenning With this fix I think all supported platforms should now report a device model corresponding to the actual device the code is running on.

FWIW the method used is similar to how other popular libraries (Firebase) gather the identifier.

Fine to merge?

manucheri avatar May 10 '24 19:05 manucheri

Thanks @manucheri

cristipufu avatar Jun 08 '24 12:06 cristipufu