snps icon indicating copy to clipboard operation
snps copied to clipboard

Refactor I/O classes

Open apriha opened this issue 4 years ago • 2 comments

Simplifies Reader and Writer classes. Adds class-based parsers (fixes #119).

apriha avatar Apr 27 '21 06:04 apriha

Codecov Report

Merging #129 (4a0fe35) into develop (68ca13e) will increase coverage by 0.10%. The diff coverage is 97.53%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #129      +/-   ##
===========================================
+ Coverage    92.87%   92.97%   +0.10%     
===========================================
  Files            8        8              
  Lines         1473     1495      +22     
  Branches       254      252       -2     
===========================================
+ Hits          1368     1390      +22     
  Misses          66       66              
  Partials        39       39              
Impacted Files Coverage Δ
src/snps/io/writer.py 86.48% <85.71%> (-0.59%) :arrow_down:
src/snps/io/reader.py 97.58% <100.00%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68ca13e...4a0fe35. Read the comment docs.

codecov-commenter avatar Apr 27 '21 06:04 codecov-commenter

Hi @willgdjones , @afaulconbridge , please check out these changes and let me know what you think. Thanks!

apriha avatar Apr 27 '21 06:04 apriha