sdk-for-node icon indicating copy to clipboard operation
sdk-for-node copied to clipboard

Published 20 hours ago • verified publisher icon appwrite

README changes

Open keul opened this issue 3 years ago • 1 comments

What does this PR do?

Fix some readme instruction that didn't worked for me on appwrite 1.1

  • ID.xxx is undefined
  • phone parameter is before password. By not providing it I get an HTTP 400 ("Invalid phone: Phone number must start with a '+' can have a maximum of fifteen digits")

keul avatar Oct 03 '22 15:10 keul

@keul Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

stnguyen90 avatar Oct 06 '22 23:10 stnguyen90

@christyjacob4 sorry I don't fully understand. This repo will remain with a wrong README? Or is it some way automatically synced with the README you are referring to?

keul avatar Oct 14 '22 09:10 keul

@keul This repository is read only.

Screenshot 2022-10-18 at 11 48 36 AM

We generate all the code and text content in this repository using the sdk-generator

Your change is completely valid. You just need to make it in the sdk-generator repo in this file https://github.com/appwrite/appwrite/blob/master/docs/sdks/nodejs/GETTING_STARTED.md

Let me know if you have any questions

christyjacob4 avatar Oct 18 '22 07:10 christyjacob4

Thanks for clarification!

keul avatar Oct 18 '22 10:10 keul

@keul Happy to help. Looking forward to your contribution :)

christyjacob4 avatar Oct 19 '22 07:10 christyjacob4