sdk-for-cli icon indicating copy to clipboard operation
sdk-for-cli copied to clipboard

Bug(cli): code.tar.gz file remains after error occurs

Open Vaibhav91one opened this issue 2 years ago • 3 comments

What does this PR do?

  • This PR mainly implements a Try catch and finally block to the functionCreateDeployment.
  • As if anything happens in between the finally block will always execute and will remove the remaining file.

Test Plan

N/A

Related PRs and Issues

  • https://github.com/appwrite/sdk-for-cli/issues/28

Have you read the Contributing Guidelines on issues?

Yes

Vaibhav91one avatar Oct 09 '23 07:10 Vaibhav91one

Hey, could you please clean up the commit and remove all the unnecessary white space type changes so we can find what changed more easily?

Sure.

Vaibhav91one avatar Oct 30 '23 17:10 Vaibhav91one

I'm going to add the hacktoberfest-accepted label just so you get credit, but we'll probably close this PR since we need the change in the SDK generator repo.

stnguyen90 avatar Oct 31 '23 22:10 stnguyen90

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

gewenyu99 avatar Apr 08 '24 20:04 gewenyu99

closing as change needs to be done in sdk-generator repo.

stnguyen90 avatar May 20 '24 22:05 stnguyen90