sdk-for-cli icon indicating copy to clipboard operation
sdk-for-cli copied to clipboard

Published 20 hours ago • verified publisher icon appwrite

code.tar.gz remains when function throws error

Open rdmchr opened this issue 3 years ago • 10 comments

I got this error when I tried deploying my function:

✗ Error Request body larger than maxBodyLength limit

After exiting the CLI did not remove the code.tar.gz file it created. I believe the CLI should remove the file even if it crashes since there is no reason to leave it.

rdmchr avatar Mar 03 '22 14:03 rdmchr

Thank you for raising this @rdmchr . We'll look into this 🙂

christyjacob4 avatar Mar 15 '22 23:03 christyjacob4

Looks like this was addressed for the case where the code is less than 5MB:

https://github.com/appwrite/sdk-for-cli/blob/b4619977eb95ca6650aa5291eb6a26d6bfa46eda/lib/commands/functions.js#L333-L338

but may still happen if the code is more than 5MB:

https://github.com/appwrite/sdk-for-cli/blob/b4619977eb95ca6650aa5291eb6a26d6bfa46eda/lib/commands/functions.js#L367

stnguyen90 avatar Jun 23 '23 21:06 stnguyen90

@Haimantika Can I work on this issue.

Vaibhav91one avatar Oct 01 '23 10:10 Vaibhav91one

@Haimantika Can I work on this issue.

Hi @Vaibhav91one , I've assigned the issue to you! Happy Hacktoberfest 🎃!

Notes:

Please update us with your progress every 3 days, so that we know you are working on it. Join us on Discord - https://appwrite.io/discord to chat about Hacktoberfest and Appwrite!

Haimantika avatar Oct 02 '23 09:10 Haimantika

@Haimantika Can I work on this issue.

Hi @Vaibhav91one , I've assigned the issue to you! Happy Hacktoberfest 🎃!

Notes:

Please update us with your progress every 3 days, so that we know you are working on it. Join us on Discord - https://appwrite.io/discord to chat about Hacktoberfest and Appwrite!

I just wanted to give an update. That I am working on this and talking to some people related to this issue.

Vaibhav91one avatar Oct 04 '23 09:10 Vaibhav91one

Will be making a PR soon.

Vaibhav91one avatar Oct 06 '23 02:10 Vaibhav91one

Will be making a PR soon.

@stnguyen90 Have made a PR please review

Vaibhav91one avatar Oct 10 '23 03:10 Vaibhav91one

Will be making a PR soon.

@stnguyen90 Have made a PR please review

Can you link the issue to the PR?

Haimantika avatar Oct 11 '23 12:10 Haimantika

Will be making a PR soon.

@stnguyen90 Have made a PR please review

Can you link the issue to the PR?

https://github.com/appwrite/sdk-for-cli/pull/99

Vaibhav91one avatar Oct 13 '23 10:10 Vaibhav91one

Hey @stnguyen90 Can you please assign me this issue.

Souptik2001 avatar Jul 18 '24 06:07 Souptik2001