console icon indicating copy to clipboard operation
console copied to clipboard

Use Local Time for Premium Support Timings

Open ItzNotABug opened this issue 1 year ago • 7 comments

What does this PR do?

Shows Local Time for Premium Support Timings

Test Plan

Manual, by changing device's timezone.

IST
IST IST-2
EST
EST EST-2
AST
AEDT AEDT-2

Related PRs and Issues

  • #933

Have you read the Contributing Guidelines on issues?

Yes.

ItzNotABug avatar Mar 07 '24 10:03 ItzNotABug

@ItzNotABug is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 07 '24 10:03 vercel[bot]

@ItzNotABug, sorry, looks like there's a conflict now. Please also make sure to re-request a review once it's ready for review.

stnguyen90 avatar Mar 08 '24 17:03 stnguyen90

@ItzNotABug, sorry, looks like there's a conflict now. Please also make sure to re-request a review once it's ready for review.

Hey @stnguyen90, I am trying to merge the changes from the main branch to this refactor branch and the merge conflict seems to work fine.

However during the commit & push, I see all the files changed in the main which would appear in the Files Changed (350+), which doesn't seem right to me.

Apologies if this is something not very trivial, but I haven't encountered this issue before 😅

ItzNotABug avatar Mar 09 '24 09:03 ItzNotABug

Seems the issues for the conflict and the one I was having above is fixed.

ItzNotABug avatar Mar 10 '24 09:03 ItzNotABug

Hey @stnguyen90, Please take a look at the changes.

Also, I couldn't get a test for the localeTimezoneName() to pass due to TZ=EST. Setting the device timezone manually works without TZ=EST. Any ideas?

Thanks.


Update: Using a Region/City like format does work , e.g: America/Panama, America/Atikokan.

ItzNotABug avatar Mar 13 '24 16:03 ItzNotABug

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 10:29pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 10:29pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 10:29pm

vercel[bot] avatar Mar 21 '24 21:03 vercel[bot]

Hey @stnguyen90, Please take a look at the changes.

Also, I couldn't get a test for the localeTimezoneName() to pass due to TZ=EST. Setting the device timezone manually works without TZ=EST. Any ideas?

Thanks.

Update: Using a Region/City like format does work , e.g: America/Panama, America/Atikokan.

@stnguyen90 Any updates on this for the localeTimezoneName() test?

ItzNotABug avatar Apr 09 '24 06:04 ItzNotABug