appsignal-javascript icon indicating copy to clipboard operation
appsignal-javascript copied to clipboard

No parameter filtering is implemented

Open tombruijn opened this issue 4 years ago • 1 comments

The JavaScript package offers a Span.setParams function but no filterParameters option is implemented like in the other integrations.

We don't call setParams anywhere ourselves in the integration packages, so any params transmitted are user submitted.

  • Is the lack of parameter filtering intentional?
  • Do we require users to filter the parameters themselves before sending an error?

To do

If we are implementing something for this.

  • [ ] Update parameter filtering guide: https://docs.appsignal.com/guides/filter-data/filter-parameters.html
  • [ ] Update parameter filtering topic: https://docs.appsignal.com/application/parameter-filtering.html
  • [ ] Add config option to JavaScript options page: https://docs.appsignal.com/front-end/configuration/

tombruijn avatar Nov 25 '21 13:11 tombruijn

Related issue: https://github.com/appsignal/integration-guide/issues/81

tombruijn avatar Jan 30 '24 12:01 tombruijn