vscode-gcode-syntax icon indicating copy to clipboard operation
vscode-gcode-syntax copied to clipboard

Add support for Siemens Sinumerik codes

Open silopolis opened this issue 4 years ago • 6 comments

First thank you veeeery much for this excellent extension !

As I'm working on a Siemens Sinumerik (840d) driven machine, I'd love to see this NC's specific codes better supported for ".mpf" and ".spf" files, mainly for syntax highlighting.

For example blocks like:

  • WORKPIECE(,,,,,,,,): for stock definition
  • MSG(""): for operator messages
  • T="TOOL_BY_NAME": for tool names
  • TRANS/ATRANS, ROT/AROT...: for transformations
  • CYCLExxx(): for positionning and machining cycles
  • MCALL: for modal sub-program calling
  • ...

WIth a little guidance, I'd gladly help for this.

Thanks again. Keep the good stuff coming

silopolis avatar May 19 '21 08:05 silopolis

I'll add this to the feature list, but probably won't get to it in 0.7.X as I think it'll require a language server

mikecentola avatar May 27 '21 01:05 mikecentola

Also, really grateful to find this project! 🎉 And eager to meet someone else on GitHub who's using a sinumerik 840D, @silopolis 👋

For reference, some other projects doing syntax highlighting for sinumerik flavour g-code:

  • https://github.com/staniska/sinumerik-highlight (atom editor)
  • https://github.com/deathaxe/sublime-s840d (sublimetext3 editor)

EDIT: oh hey, just stumbled across what a language server was (hadn't heard of it) https://github.com/Microsoft/language-server-protocol

patcon avatar Jun 22 '21 02:06 patcon

@mikecentola, first of all thank you so much for creating this amazing extension !

It's been 5 years since I'm working as a CNC Engineer and programming for different CN controller, such as Heidenhain, NUM1060, FANUC and Siemens (840d), via CAD/CAM System like CATIA or PTC Creo.

I'm working a lot with NUM1060 language, and it really looks like GCode.

How can I do if I want to add this language, I don't know how to start and I have few questions in mind :

  • Do you prefer to stay for one specific CN Language ? and then maybe copy this project for another language, if so tell me more about the Licence, I really want to be clean about that.

  • If no, adding specific language features inside your code, but it kinds of bugs me because all the files/logo reference 'G-Code' and it will no longer be the case after that, it will be more 'CNC-Code' or something, if you know what I mean.

I will really appreciate your feedback after that and guide me how I can support.

PS: Sorry for the mistakes, I'm French...

darkross67 avatar Feb 10 '22 20:02 darkross67

@mikecentola, first of all thank you so much for creating this amazing extension !

It's been 5 years since I'm working as a CNC Engineer and programming for different CN controller, such as Heidenhain, NUM1060, FANUC and Siemens (840d), via CAD/CAM System like CATIA or PTC Creo.

I'm working a lot with NUM1060 language, and it really looks like GCode.

How can I do if I want to add this language, I don't know how to start and I have few questions in mind :

  • Do you prefer to stay for one specific CN Language ? and then maybe copy this project for another language, if so tell me more about the Licence, I really want to be clean about that.

  • If no, adding specific language features inside your code, but it kinds of bugs me because all the files/logo reference 'G-Code' and it will no longer be the case after that, it will be more 'CNC-Code' or something, if you know what I mean.

I will really appreciate your feedback after that and guide me how I can support.

PS: Sorry for the mistakes, I'm French...

I know some machine tools may use other types of characters and function codes but I don't think we'd be disingenuous by keeping the name as "G-Code"

I think as soon as we can figure out the dynamic language server and get some more contributors to the gcode-reference project, it'll become very easy to add variations.

mikecentola avatar Feb 12 '22 20:02 mikecentola

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 02 '22 07:08 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity.

github-actions[bot] avatar Oct 02 '22 07:10 github-actions[bot]