drone-jenkins
drone-jenkins copied to clipboard
Fix jenkins.go false negative result when triggering Jenkins job.
When triggering a Jenkins job, Jenkins API call returns 200 OK but drone-jenkins expects 201. So, the trigger succeeded but drone-jenkins returns false negative.
The Jenkins version I am using to test this is 2.346.3
The way in which drone-jenkins is used is via the jenkins-action:
https://github.com/appleboy/jenkins-action/blob/master/entrypoint.sh
Summary of Changes
Hello @stliang, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a specific problem where the drone-jenkins client was incorrectly flagging successful Jenkins job triggers as failures. The Jenkins API can return an HTTP 200 OK status for a successful trigger, but the client was only expecting HTTP 201 Created. By modifying the response validation logic, the client now correctly recognizes both status codes as indicators of success, ensuring accurate reporting of job trigger outcomes.
Highlights
- False Negative Fix: Resolved an issue where
drone-jenkinswould report a false negative result when triggering a Jenkins job, even if the job trigger was successful. - HTTP Status Code Handling: Updated the
jenkins.gofile to correctly interpret bothHTTP 200 OKandHTTP 201 Createdas successful responses from the Jenkins API when triggering a job.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.