swift-http-types
swift-http-types copied to clipboard
Move HTTPRequest.url to the main library
Resolves #76
Are there ways to re-export these symbols so we don't need to introduce API breakages?
2 breaking changes detected in HTTPTypesFoundation:
💔 API breakage: var HTTPRequest.url has been removed
💔 API breakage: constructor HTTPRequest.init(method:url:headerFields:) has been removed
Maybe @_exported import or @_disfavoredOverload?
@_exported import is totally workable.
@_exported import doesn't seem to address the API breakage check. Maybe the check itself is too strict?
API breakage is usually strict, and I think this is one way in which it is.
@guoye-zhang hey, any updates here
This requires an admin to take action since it fails the ABI breakage check
Can you update the branch to resolve the conflicts. I can help with getting it merged.
Rebased. I think this is a "semver/minor" change since it technically adds an API?
This is the output
2 breaking changes detected in HTTPTypesFoundation:
💔 API breakage: var HTTPRequest.url has been removed
💔 API breakage: constructor HTTPRequest.init(method:url:headerFields:) has been removed
Error: Process completed with exit code 1.
but I think that's bogus because of the @_exported import which brings those APIs back. @FranzBusch how do we override that check?
Amazing, thanks @guoye-zhang & @Lukasa , I'd appreciate a release with this change so we can update and remove our copies of this code base. Thank you
I just tagged 1.5.0 with this change