swift-distributed-actors icon indicating copy to clipboard operation
swift-distributed-actors copied to clipboard

Finishing clusterd

Open akbashev opened this issue 1 year ago • 11 comments

Quite often people ask "How actors find each other" and clusterd could be a good example to show discoverability.

Again just stealing your code here @ktoso 🙂 Will just try to finish and prettify.

akbashev avatar Oct 15 '24 16:10 akbashev

@ktoso we can focus on your PR though, can close this one. It's just easier for me to finish it here.

akbashev avatar Oct 15 '24 16:10 akbashev

Happy for you to take it over. Fixed up CI so we now just do 5.10+ jobs.

ktoso avatar Oct 16 '24 01:10 ktoso

@ktoso I've went through code, cleaned up some stuff, executable is now called swift-clusterd and tested myself, test is also working. Except for ClusterD should be a "HIDDEN" member in the membership mentioned in original PR think it's already in a good shape to be merged.

akbashev avatar Nov 05 '24 16:11 akbashev

Hey guys is there any movement on this?

zastrozzi avatar Feb 18 '25 04:02 zastrozzi

@zastrozzi Hi! 👋 There are currently some really weird issues with tests that need to be tackled before we can merge everything. I will try again to check, but probably will take some time.

akbashev avatar Feb 18 '25 15:02 akbashev

Hey no worries! If I have some time I'll see if I can help too. Are the testing problems cited elsewhere in an issue/PR?

zastrozzi avatar Feb 18 '25 22:02 zastrozzi

Hey no worries! If I have some time I'll see if I can help too. Are the testing problems cited elsewhere in an issue/PR?

There is this issue, but it's really strange one, will try to ping and check once more.

akbashev avatar Feb 20 '25 08:02 akbashev

we don't do API breakage, we could remove that, we're pre-1.0

ktoso avatar May 01 '25 09:05 ktoso

we don't do API breakage, we could remove that, we're pre-1.0

Hm, can you elaborate a bit more? It's not really breaking anything, but you mean you don't wanna add something new to pre-1.0 and 1.0?

akbashev avatar May 01 '25 11:05 akbashev

The Pr validation triggered api compatibility checking, so I was saying we can disable that basically :)

ktoso avatar May 01 '25 12:05 ktoso

The Pr validation triggered api compatibility checking, so I was saying we can disable that basically :)

ah, ok, was confused a bit. 🙂

akbashev avatar May 01 '25 12:05 akbashev