swift-distributed-actors icon indicating copy to clipboard operation
swift-distributed-actors copied to clipboard
verified publisher icon apple

Fixed WorkerPool to handle remote actors properly

Open akbashev opened this issue 1 year ago • 2 comments

Currently WorkerPool:

  • Treats remote actors as weak and cleans them directly
  • Doesn't work on Swift 6 mode as WorkItem and WorkResult are not marked as Sendable

This PR fixes this, basically cherry picked changes from this PR https://github.com/apple/swift-distributed-actors/pull/1159 and updated tests

akbashev avatar Oct 15 '24 13:10 akbashev

Hm, would be nice to add test to check remote actors also.

akbashev avatar Oct 15 '24 15:10 akbashev

@swift-server-bot test this please

ktoso avatar Nov 06 '24 10:11 ktoso

@ktoso ClusterSingletonPluginClusteredTests is flacky, also seen it failing in main branch, need to check it separately.

akbashev avatar Sep 10 '25 05:09 akbashev

Hm yeah some tests are flaky, the docs validation is also failing.

This did pass on many runs though so I'm ok to merge and we need to get CI more stable eventually

ktoso avatar Sep 13 '25 02:09 ktoso