swift-crypto
swift-crypto copied to clipboard
Make NIST `PublicKey`s conform to `Equatable`
Make NIST PublicKey's (P256, P384 and P521) conform to Equatable
Checklist
- [x] I've run tests to see all new and existing tests pass
- [x] I've followed the code style of the rest of the project
- [x] I've read the Contribution Guidelines
- [x] I've updated the documentation if necessary
If you've made changes to gyb files
- [x] I've run
.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull request
Motivation:
There is really no drawback in adding Equatable conformance, as argued in #173
Modifications:
- Make
P256,P384andP521's Signing and KeyAgreementPublicKeybeEquatable, by... - ... marking
NISTECPublicKeyto beEquatableand adding equals function inECDH.swift.gyb - Add tests for these.
Result:
ALL NIST PublicKey's now conform to Equatable
As with #173, I'm marking this as Request Changes just as a visual note to myself to return to it.