password-manager-resources icon indicating copy to clipboard operation
password-manager-resources copied to clipboard

quirks/websites-with-shared-credential-backends.json should be removed

Open erynofwales opened this issue 1 year ago • 5 comments

quirks/websites-with-shared-credential-backends.json is a legacy data file that has been replaced by quirks/shared-credentials.json. We should remove it.

erynofwales avatar Sep 27 '24 23:09 erynofwales

Yeah, I think it's time. My plan for this is to change the script that converts to the legacy format to take a required output path, then remove the legacy file. Then any password manager who still wants to use the legacy format can use the script on their side, instead of making all contributors do the conversion.

How does this sound? @Cldfire @bradcush

rmondello avatar Sep 29 '24 13:09 rmondello

Yea that makes sense, I'm for it. Also thinking out loud that It could be beneficial adding a few small test cases to the CI at some point later since there will no longer be any trace of an artifact in the repository to manually check against. Just to make sure it's working given any kind of updates and it can also serve as a doc for the old format.

bradcush avatar Oct 01 '24 18:10 bradcush

@rmondello that sounds good to me!

(Do note however that I no longer work at 1Password, so I can't speak for them.)

Cldfire avatar Oct 01 '24 19:10 Cldfire

@Cldfire Oh gosh, I'm so embarrassed! My apologies! (But thank you for chiming in regardless.)

rmondello avatar Oct 01 '24 19:10 rmondello

Oh no worries at all! I just wanted to make sure I clarified 😄

Cldfire avatar Oct 01 '24 19:10 Cldfire