llvm-project
llvm-project copied to clipboard
Change lldb breakpoint and stepping algorithm
@swift-ci test
Windows CI had one failure on TestConsecutiveBreakpoints,
======================================================================
FAIL: test_single_step_thread_specific (TestConsecutiveBreakpoints.ConsecutiveBreakpointsTestCase)
Test that single step stops, even though the second breakpoint is not valid.
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\llvm-project\lldb\packages\Python\lldbsuite\test\decorators.py", line 452, in wrapper
return func(self, *args, **kwargs)
File "C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\llvm-project\lldb\test\API\functionalities\breakpoint\consecutive_breakpoints\TestConsecutiveBreakpoints.py", line 121, in test_single_step_thread_specific
self.finish_test()
File "C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\llvm-project\lldb\test\API\functionalities\breakpoint\consecutive_breakpoints\TestConsecutiveBreakpoints.py", line 42, in finish_test
self.assertState(self.process.GetState(), lldb.eStateExited)
File "C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\llvm-project\lldb\packages\Python\lldbsuite\test\lldbtest.py", line 2590, in assertState
self.fail(self._formatMessage(msg, error))
AssertionError: stopped (5) != exited (10)
Config=x86_64-T:\5\bin\clang.exe
FAILED (failures=1)
which is the kind of test that would detect an actual regression, will try re-running once again but I might have to stare at ProcessWindowsNative and this test and see if I can't imagine what is happening.
@swift-ci test windows
@swift-ci test windows
@swift-ci test
@swift-ci test
Created new PR with the cherrypicks on top of stable/20240723, wasn't completely confident rebasing this. The test failing is something added to the branch before I branched, so I can't build & debug it from the branch. https://github.com/swiftlang/llvm-project/pull/10377