python-client icon indicating copy to clipboard operation
python-client copied to clipboard

Published 20 hours ago • verified publisher icon appium

add timeout for server stop as method param

Open LykashevichAndrei opened this issue 1 year ago • 4 comments

LykashevichAndrei avatar Sep 24 '24 09:09 LykashevichAndrei

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: LykashevichAndrei / name: LukashevichAndrei (e1685865bd1a858ac6858b99b6486c85f385e97b)
  • :white_check_mark: login: KazuCocoa / name: Kazuaki Matsuo (1a26a13b13c62bfba59130a94aa05eb0f3980848, d586360750e794afa94fefbaa745bb5a9665e644)

linux-foundation-easycla[bot] avatar Sep 24 '24 09:09 linux-foundation-easycla[bot]

I am not sure what you are trying to achieve by this PR. Active connections close timeout is currently hardcoded on the server side and won't be affected by the process timeout.

mykola-mokhnach avatar Sep 24 '24 11:09 mykola-mokhnach

https://github.com/appium/python-client/issues/1027

at least for now i will not see error on test postconditions that appium server was not closed

however this is a good catch and i will review appium server code and may be provide another PR to avoid this hardcode

LykashevichAndrei avatar Sep 24 '24 11:09 LykashevichAndrei

Please rename the PR to comply with the https://www.conventionalcommits.org/en/v1.0.0/ standard

mykola-mokhnach avatar Sep 24 '24 15:09 mykola-mokhnach

Closed in favour of https://github.com/appium/python-client/pull/1038

mykola-mokhnach avatar Oct 04 '24 20:10 mykola-mokhnach