rails-forward_compatible_controller_tests icon indicating copy to clipboard operation
rails-forward_compatible_controller_tests copied to clipboard

Published 20 hours ago • verified publisher icon appfolio

Skipping calls with a format?

Open srvance opened this issue 5 years ago • 1 comments

With raise_exception set, I had a bunch of controllers that weren't erroring out as I expected. I found this code that seems to assume that if it specifies a format, even if it's something like :json, that it won't treat it as an old method.

It looks like it was deliberately added as part of #12, but there's no explanation of the exclusion. Is this a bug or is there a good reason I'm missing?

It would make sense to me for a presentational type, like :html, perhaps, but not for data payload types.

srvance avatar May 22 '20 18:05 srvance

Similar path... but possibly a separate bug. Happy to file one off.

If params is a string (like a json payload), AND format is specified, then this bit makes request_params and string and then bombs on this other bit in the same method because that is clearly expecting a hash.

zenspider avatar May 23 '20 01:05 zenspider