rover
rover copied to clipboard
apollographql
Update curl installer message for anonymized usage collection
While installing rover I noticed that the message printed for disabling the anonymized usage collection was still suggesting to set APOLLO_TELEMETRY_DISABLED=1.
But since the release v0.18.1 the recommendation was changed to use the boolean flag.
This PR updates the message for the curl installer. For the npm installer this message was already correct/updated.
@hpuac: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/
✅ Docs preview has no changes
The preview was not built because there were no changes.
Build ID: 8dfbca586bf0be572dd529c8
Today marks the one-year anniversary of this open PR. I hope you allow me a sarcastic comment: Thank you Apollo for taking Open Source so serious and supporting individual contributors as much as you do. Even if the change is trivial I like how much you encourage contributors and support them which increases their motivation to do even more changes and contribute to your business. This is a true inspiration for the whole tech industry, thank you! /sarcasm off I will not try to keep this PR up to date anymore. Take them over or close the PR, both is fine for me, in the end it's just two lines changed.
Today marks the one-year anniversary of this open PR. I hope you allow me a sarcastic comment: Thank you Apollo for taking Open Source so serious and supporting individual contributors as much as you do. Even if the change is trivial I like how much you encourage contributors and support them which increases their motivation to do even more changes and contribute to your business. This is a true inspiration for the whole tech industry, thank you! /sarcasm off I will not try to keep this PR up to date anymore. Take them over or close the PR, both is fine for me, in the end it's just two lines changed.
@hpuac - Sorry for the absurdly long delay. We've just started up a new tooling team here at Apollo which should allow us to more effeciently handle external pull requests (though admittedly one year is a very low bar to improve upon!). Thanks for your interest and contributions to Apollo!
Closing in favor of #2448. The required GitHub actions for end-to-end tests in this repo aren't currently configured to work with PRs from forks. Since these changes are small, it's easier to just put them in a new PR. Sorry again for the delay on this.