router icon indicating copy to clipboard operation
router copied to clipboard

fix(federation/composition): fixed context spec's argument type computation

Open duckki opened this issue 5 months ago • 2 comments

Updated ContextSpecDefinition::field_argument_specification to retrieve the referenced type name using the provided link argument to the get_type closure. Also, refactored to share the argument name constant from the federation spec module.

Note: The ContextSpecDefinition is used for both federation spec and context spec. The link argument provides the correct context to the closure.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [x] PR description explains the motivation for the change and relevant context for reviewing
  • [ ] PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • [ ] Changeset is included for user-facing changes
  • [x] Changes are compatible[^1]
  • [ ] Documentation[^2] completed
  • [x] Performance impact assessed and acceptable
  • [ ] Metrics and logs are added[^3] and documented
  • Tests added and passing[^4]
    • [ ] Unit tests
    • [ ] Integration tests
    • [x] Manual tests, as necessary

duckki avatar Jun 19 '25 03:06 duckki

@duckki, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

github-actions[bot] avatar Jun 19 '25 03:06 github-actions[bot]

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed
* (developer-tools)/apollo-mcp-server/(latest)/command-reference.mdx
* (developer-tools)/apollo-mcp-server/(latest)/guides/index.mdx

Build ID: fee40f36261dc6bcb1a2e84b

URL: https://www.apollographql.com/docs/deploy-preview/fee40f36261dc6bcb1a2e84b

apollo-librarian[bot] avatar Jun 19 '25 03:06 apollo-librarian[bot]

@tninesling Welcome back!

duckki avatar Jun 26 '25 19:06 duckki