router
router copied to clipboard
Add ->ne connectors method
Add ->ne connectors method
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
- [x] Changes are compatible[^1]
- [ ] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- [ ] Metrics and logs are added[^3] and documented
- Tests added and passing[^4]
- [x] Unit Tests
- [ ] Integration Tests
- [ ] Manual Tests
Exceptions
Note any exceptions here
Notes
[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]: A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.
[^4]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.
@andrewmcgivery, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.
✅ Docs preview has no changes
The preview was not built because there were no changes.
Build ID: 412b1179349dad08da6e9995
Since my review comments may have gotten buried:
- https://github.com/apollographql/router/pull/7715#discussion_r2159228087
- https://github.com/apollographql/router/pull/7715#discussion_r2159220139