router icon indicating copy to clipboard operation
router copied to clipboard

Optional chaining for selection syntax

Open andrewmcgivery opened this issue 5 months ago • 3 comments

Optional chaining for selection syntax


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [ ] Changes are compatible[^1]
  • [ ] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • [ ] Metrics and logs are added[^3] and documented
  • Tests added and passing[^4]
    • [ ] Unit Tests
    • [ ] Integration Tests
    • [ ] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices. [^4]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

andrewmcgivery avatar Jun 06 '25 19:06 andrewmcgivery

@andrewmcgivery, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

github-actions[bot] avatar Jun 06 '25 19:06 github-actions[bot]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 2e3fbd620f0912476e846c7a Build Logs: View logs

apollo-librarian[bot] avatar Jun 09 '25 02:06 apollo-librarian[bot]

EDIT: This has been resolved after discussion with Ben. :)

In apply_to.rs, Ben's code has a change to the Property {} not found in {} logic. I think this is making it not return errors on not found properties if they are immediately followed by a ? since ? applies that whatever comes immediately before it is infact nullable and so not an error if not found at all.

andrewmcgivery avatar Jun 09 '25 03:06 andrewmcgivery