Add test ensuring we don't cache temporary query planner errors (backport #7218)

[Velfi]

This PR adds tests and removes an unused error variant.

Fixes #issue_number

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• [x] Changes are compatible[^1]
• [x] Documentation[^2] completed
• [x] Performance impact assessed and acceptable
• Tests added and passing[^3]
  • [x] Unit Tests
  • [x] Integration Tests
  • [x] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

---

This is an automatic backport of pull request #7218 done by [Mergify](https://mergify.com).

[mergify[bot]]

Cherry-pick of 3e08471b9b54332ecd49c375823064f9e836a8da has failed:

On branch mergify/bp/1.x/pr-7218
Your branch is ahead of 'origin/1.x' by 2 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 3e08471b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    apollo-router/src/query_planner/testdata/starstuff.graphql

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   apollo-router/src/query_planner/caching_query_planner.rs

Cherry-pick of 13e338b3313b1c73582192908db64b11cb9d6250 has failed:

On branch mergify/bp/1.x/pr-7218
Your branch is ahead of 'origin/1.x' by 3 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 13e338b3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   apollo-router/src/query_planner/caching_query_planner.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[router-perf[bot]]

CI performance tests

• [ ] connectors-const - Connectors stress test that runs with a constant number of users
• [x] const - Basic stress test that runs with a constant number of users
• [ ] demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
• [ ] demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
• [ ] enhanced-signature - Enhanced signature enabled
• [ ] events - Stress test for events with a lot of users and deduplication ENABLED
• [ ] events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
• [ ] events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
• [ ] events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
• [ ] events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
• [ ] events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
• [ ] extended-reference-mode - Extended reference mode enabled
• [ ] large-request - Stress test with a 1 MB request payload
• [ ] no-tracing - Basic stress test, no tracing
• [ ] reload - Reload test over a long period of time at a constant rate of users
• [ ] step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
• [ ] step-local-metrics - Field stats that are generated from the router rather than FTV1
• [ ] step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
• [x] step - Basic stress test that steps up the number of users over time
• [ ] xlarge-request - Stress test with 10 MB request payload
• [ ] xxlarge-request - Stress test with 100 MB request payload

[svc-apollo-docs]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: f765123a065507cf9e9f286f

[apollo-librarian[bot]]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 4624079644fc6239d4c59475

[Velfi]

~closing this since the test is broken and we have more important things to deal with.~