router icon indicating copy to clipboard operation
router copied to clipboard

Move the rest of the license enforcement functionality into plugin

Open BrynCooke opened this issue 9 months ago • 3 comments

This significantly simplifies the axum server factory as it no longer has to care about licenses.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [ ] Changes are compatible[^1]
  • [ ] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • [ ] Unit Tests
    • [ ] Integration Tests
    • [ ] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

BrynCooke avatar Feb 12 '25 14:02 BrynCooke

@BrynCooke, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

github-actions[bot] avatar Feb 12 '25 14:02 github-actions[bot]

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/reference/upgrade/from-router-v1.mdx

Build ID: 46d8065b9376dce87f23972f

URL: https://www.apollographql.com/docs/deploy-preview/46d8065b9376dce87f23972f

svc-apollo-docs avatar Feb 12 '25 14:02 svc-apollo-docs

Is it OK if we land this post-2.0.0?

goto-bus-stop avatar Feb 13 '25 13:02 goto-bus-stop